On Fri, 28 Jan 2022 at 17:50, Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Fri, Jan 28, 2022 at 04:55:35PM +0000, Peter Maydell wrote: > > Coverity points out that we aren't checking the return value > > from curl_easy_setopt() for any of the calls to it we make > > in block/curl.c. > > > > Fixes: Coverity CID 1459336, 1459482, 1460331 > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > --- > > Big fat disclaimer: tested only with 'make check', which I suspect > > may not be exercising this block backend. Hints on how to test > > more thoroughly are welcome. > > yeah afaik, qemu-iotests don't have support for this. As a very > basic smoke test do > [command lines snipped]
Thanks; yes, those both work. -- PMM