Markus Armbruster <arm...@redhat.com> writes:
> John Snow <js...@redhat.com> writes:
>
>> Get isort and pylint tools passing again.
>>
>> Signed-off-by: John Snow <js...@redhat.com>
>> ---
>> scripts/qapi/commands.py | 2 +-
>> scripts/qapi/pylintrc | 15 +++++----------
>> scripts/qapi/types.py | 6 +++++-
>> scripts/qapi/visit.py | 6 +++++-
>> 4 files changed, 16 insertions(+), 13 deletions(-)
>>
>> diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py
>> index 869d799ed22..38ca38a7b9d 100644
>> --- a/scripts/qapi/commands.py
>> +++ b/scripts/qapi/commands.py
>> @@ -25,8 +25,8 @@
>> QAPIGenC,
>> QAPISchemaModularCVisitor,
>> build_params,
>> - ifcontext,
>> gen_special_features,
>> + ifcontext,
>> )
>> from .schema import (
>> QAPISchema,
>> diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
>> index b259531a726..1fed2e69620 100644
>> --- a/scripts/qapi/pylintrc
>> +++ b/scripts/qapi/pylintrc
>> @@ -34,16 +34,11 @@ disable=fixme,
>>
>> [BASIC]
>>
>> -# Good variable names which should always be accepted, separated by a comma.
>> -good-names=i,
>> - j,
>> - k,
>> - ex,
>> - Run,
>> - _,
>> - fp, # fp = open(...)
>> - fd, # fd = os.open(...)
>> - ch,
>> +# Good variable names regexes, separated by a comma. If names match any
>> regex,
>> +# they will always be accepted
>> +
>> +# Allow just about anything, as per Markus's preference.
>
> Does it still flag PEP-8 violations like all lower case class names?
Looks like it in my tests.
> If yes, "just about any length" is more precise.
I'll change the comment if you don't mind:
# Suppress complaints about short names. PEP-8 is cool with them,
# and so are we.
With that:
Reviewed-by: Markus Armbruster <arm...@redhat.com>
No respin necessary.
