On Mon, Mar 28, 2022 at 09:59:16AM -0300, Daniel Henrique Barboza wrote: > Hi, > > This is a memory leak found by Valgrind when testing vcpu > hotplug/unplug in pSeries guests. > > Other vcpu hotplug/unplug leaks are still present in the common code > (one in the KVM thread loop and another in cpu_address_space via > cpu->cpu_ases) but these are already being handled by Mark Kanda and > Phillipe.
Changes LGTM, but I don't see much reason to split this into two patches. They're both small, and are part of the same logical change. > > > Daniel Henrique Barboza (2): > hw/ppc/ppc.c: add cpu_ppc_tb_free() > hw/ppc: free env->tb_env in spapr_unrealize_vcpu() > > hw/ppc/ppc.c | 7 +++++++ > hw/ppc/spapr_cpu_core.c | 3 +++ > include/hw/ppc/ppc.h | 1 + > 3 files changed, 11 insertions(+) > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature