On 3/29/22 05:36, Cédric Le Goater wrote:
On 3/29/22 03:24, David Gibson wrote:
On Mon, Mar 28, 2022 at 09:59:16AM -0300, Daniel Henrique Barboza wrote:
Hi,
This is a memory leak found by Valgrind when testing vcpu
hotplug/unplug in pSeries guests.
Other vcpu hotplug/unplug leaks are still present in the common code
(one in the KVM thread loop and another in cpu_address_space via
cpu->cpu_ases) but these are already being handled by Mark Kanda and
Phillipe.
Changes LGTM, but I don't see much reason to split this into two
patches. They're both small, and are part of the same logical change.
I did it in separated patches because I tried to find other instances where
the timebase would need to be freed. Didn't find any.
I am ok with squashing them in a single patch. I'll send a v2.
And it could be a 7.0 candidate. Are we ok with that ?
Since it's a memory leak we are now aware of and have a fix for, yeah, I think
it qualifies for 7.0.
Daniel
Thanks,
C.
