Hi,
On 12/04/2022 22.25, Gautam Agrawal wrote:
[...]>> On 08/04/2022 12.45, Gautam Agrawal wrote:
This patch is in regards to this
issue:https://gitlab.com/qemu-project/qemu/-/issues/581#.
Better write this right in front of your Signed-off-by line:
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/581
... then the ticket will be automatically be closed once your patch gets merged.
I apologize for this mistake
No need to apologize, it was just a hint for a minor improvement - and
you've got the other patch formatting very right already :-)
vga_interface_type is also used in hw/mips/fuloong2e.c and
hw/xenpv/xen_machine_pv.c ... do they need a change, too?
I can definitely make similar changes in them too since they also
specify the vga_interface_type, shall I proceed with this?
This will trigger a warning from the scripts/checkpatch.pl script:
ERROR: do not initialise globals to 0 or NULL
#238: FILE: softmmu/globals.c:43:
+bool vga_interface_created = false;
Could you kindly suggest a better approach to this than creating a
global variable.
Global variables are fine, simply drop the "= false" at the end of the line.
All global variables are always pre-initialized to 0, so global boolean
variables are set to 0 (i.e. false) by default, too.
I'm not a native speaker, and maybe it's just a matter of taste, but I'd
rather say it in past tense: "No VGA device has been created"
I will correct the warning message, as suggested by Peter Maydell.
Great, thank you!
Thomas