On Sun, 17 Apr 2022 at 18:58, Richard Henderson <richard.hender...@linaro.org> wrote: > > Instead of computing > > tmp1 = shift & 0xff; > dest = (tmp1 > 0x1f ? 0 : value) << (tmp1 & 0x1f) > > use > > tmpd = value << (shift & 0x1f); > dest = shift & 0xe ? 0 : tmpd;
Typo here: should be "0xe0". Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM