On Sat, Jun 11, 2022 at 5:27 PM Bernhard Beschow <shen...@gmail.com> wrote: > On Fri, Jun 10, 2022 at 4:04 PM Philippe Mathieu-Daudé <f4...@amsat.org> > wrote: >> On 5/6/22 17:19, Bernhard Beschow wrote: >> > Fixes compilation due to false positives with -Werror: >> > >> > In file included from /usr/include/glib-2.0/glib.h:114, >> > from qemu/src/include/glib-compat.h:32, >> > from qemu/src/include/qemu/osdep.h:144, >> > from ../src/hw/mips/boston.c:20: >> > In function ‘g_autoptr_cleanup_generic_gfree’, >> > inlined from ‘boston_mach_init’ at ../src/hw/mips/boston.c:790:52: >> > /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: >> > ‘dtb_load_data’ may be used uninitialized [-Werror=maybe-uninitialized] >> > 28 | g_free (*pp); >> > | ^~~~~~~~~~~~ >> > ../src/hw/mips/boston.c: In function ‘boston_mach_init’: >> > ../src/hw/mips/boston.c:790:52: note: ‘dtb_load_data’ was declared here >> > 790 | g_autofree const void *dtb_file_data, >> > *dtb_load_data; >> > | ^~~~~~~~~~~~~ >> > In function ‘g_autoptr_cleanup_generic_gfree’, >> > inlined from ‘boston_mach_init’ at ../src/hw/mips/boston.c:790:36: >> > /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: >> > ‘dtb_file_data’ may be used uninitialized [-Werror=maybe-uninitialized] >> > 28 | g_free (*pp); >> > | ^~~~~~~~~~~~ >> > ../src/hw/mips/boston.c: In function ‘boston_mach_init’: >> > ../src/hw/mips/boston.c:790:36: note: ‘dtb_file_data’ was declared here >> > 790 | g_autofree const void *dtb_file_data, >> > *dtb_load_data; >> > | ^~~~~~~~~~~~~ >> > cc1: all warnings being treated as errors >> > >> > Signed-off-by: Bernhard Beschow <shen...@gmail.com> >> > --- >> > hw/mips/boston.c | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> >> Queued via mips-next. > > > Hi Phil, > > shouldn't this patch be visible in your pull request then? > https://patchew.org/QEMU/20220611103312.67773-1-philippe.mathieu.da...@gmail.com/
It was included, but I have been overzealous when removing Mark's PS2 series and removed it as well :/ > Best regards, > Bernhard