On Wed, Oct 12, 2022 at 10:59:54AM +0200, Paolo Bonzini wrote: > On 10/12/22 10:14, Daniel P. Berrangé wrote: > > > Daniel, does building the TCG tests work for you? If not, I think we > > > should > > > just disable containers by default. > > > > I've never (knowingly) tried running TCG tests. IIUC, they are strictly > > an opt-in test needing explicit 'make check-tcg', so any container usage > > wouldn't be encountered by most contributors ? > > Yeah, that is true. But the problems below affect all container usage > rather than just firmware builds, so they should be fixed there. configure > is able to only run 'make check-tcg' for targets which have a compiler > installed. > > > IOW, I'd like to see > > > > - Explicit opt-in at configure time for use of container > > downloads during 'make' > > This is what I'm proposing, and extending to all targets.
Ok, makes sense. > > - Tailor downloads wrt the target list configured > > This is already done. Where's the patch for that, I hadn't noticed it being posted yet ? > > - Suppress the verbose output to preserve meson progress > > readability > > That's in general a tradeoff with long-running tasks. It's difficult to say > which is better, for example "make check" also has a verbose output. If 'make' was running with V=1, then also letting docker download be verbose makes sense. The plain 'make' though is intentionally quite terse, just giving a list of files meson compiles. Right now, the output ends up looking like this: [2715/2945] Compiling C object tests/unit/test-xbzrle.p/test-xbzrle.c.o [2716/2945] Linking target tests/unit/test-authz-pam Copying blob bd159e379b3b skipped: already exists Copying blob fc8d65e34cd5 [>-------------------------------------] 9.3MiB / 360.2MiB Copying blob 13224e2971af [--------------------------------------] 1.1MiB / 366.5MiB [2720/2945] Linking target tests/unit/test-io-channel-tls Copying blob bd159e379b3b skipped: already exists Copying blob fc8d65e34cd5 [>-------------------------------------] 9.4MiB / 360.2MiB Copying blob 13224e2971af [--------------------------------------] 1.2MiB / 366.5MiB [2724/2945] Linking target tests/unit/test-io-task [2725/2945] Compiling C object tests/unit/test-util-sockets.p/test-util-sockets.c.o [2726/2945] Compiling C object tests/unit/test-util-sockets.p/socket-helpers.c.o [2727/2945] Linking target tests/unit/test-xbzrle [2728/2945] Compiling C object tests/unit/test-base64.p/test-base64.c.o [2729/2945] Linking target tests/unit/test-timed-average [2730/2945] Compiling C object tests/unit/test-bufferiszero.p/test-bufferiszero.c.o Copying blob bd159e379b3b skipped: already exists Copying blob 2a205c8a1d36 [>-------------------------------------] 4.4MiB / 257.2MiB Copying blob bd159e379b3b skipped: already exists Copying blob fc8d65e34cd5 [>-------------------------------------] 9.5MiB / 360.2MiB Copying blob 13224e2971af [--------------------------------------] 1.3MiB / 366.5MiB [2736/2945] Compiling C object tests/unit/test-yank.p/test-yank.c.o [2737/2945] Compiling C object tests/unit/test-util-filemonitor.p/test-util-filemonitor.c.o Copying blob bd159e379b3b skipped: already exists Copying blob fc8d65e34cd5 [>-------------------------------------] 9.6MiB / 360.2MiB Copying blob 13224e2971af [--------------------------------------] 1.3MiB / 366.5MiB which I feel is quite unplesant, especially when you then get multiple parallel docker downloads concurrently refreshing the screen and overwriting each others' output. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
