Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben: > These functions end up calling bdrv_*() implemented as generated_co_wrapper > functions. > In addition, they also happen to be always called in coroutine context, > meaning all callers are coroutine_fn. > This means that the g_c_w function will enter the qemu_in_coroutine() > case and eventually suspend (or in other words call qemu_coroutine_yield()). > Therefore we need to mark such functions coroutine_fn too. > > Signed-off-by: Emanuele Giuseppe Esposito <eespo...@redhat.com>
Here, too, it would be better to convert the callers to new blk_co_*() wrappers instead of going through g_c_w even though we know that we are in coroutine context. Doesn't make the patch less correct, though. Reviewed-by: Kevin Wolf <kw...@redhat.com>