On Mon, Jan 09, 2012 at 10:59:04AM -0600, Mark Langsdorf wrote: > This adds very basic support for XG-mac ethernet core from Synopsis and > others. Missing things include: > > - statistics counters > - WoL support > - rx checksum offload > - chained descriptors (only linear descriptor ring) > - broadcast and multicast handling > > Signed-off-by: Rob Herring <rob.herr...@calxeda.com> > Signed-off-by: Mark Langsdorf <mark.langsd...@calxeda.com> > --- > Changes from v4 > None > Changes from v3 > Added debug macro and cleaned up some debug code > Refitted all lines to fit within 80 columns > Changes from v2 > None > Changes from v1 > Reformated most lines to fit within 80 columns > Removed a bunch of unused variables in the state structures > Got rid of some camelcase structure names
Hi, this looks good to me, just one question. Do you really need the c_phyaddr member? Cheers