On 11 January 2012 15:26, Mark Langsdorf <mark.langsd...@calxeda.com> wrote: > This adds very basic support for XG-mac ethernet core from Synopsis and > others.
> +typedef struct rxtx_stats { > + uint64_t rx_bytes; > + uint64_t tx_bytes; > + > + uint64_t rx; > + uint64_t rx_bcast; > + uint64_t rx_mcast; > +} rxtx_stats; Anthony pointed out to me on IRC today the bit of CODING_STYLE that mandates CamelCase for struct typedef names. Sorry to bring up coding style issues at this point in the review process, but can I get you to go through and camelcase the struct typenames in this patch series? thanks -- PMM