On 12/13/22 10:10, Philippe Mathieu-Daudé wrote:
On 13/12/22 17:00, Richard Henderson wrote:
On 12/13/22 06:52, Philippe Mathieu-Daudé wrote:
Assuming the developers of commits 2c50e26efd ("powerpc: Add
a virtex5 ml507 refdesign board") and 4b387f9ee1 ("ppc: Add
aCube Sam460ex board") were testing on a little-endian setup,
they meant to use const_le32() instead of tswap32() here,
since tswap32() depends on the host endianness.
tswap depends on target endianness.
Yes, it depends on both host/target endianness. What I meant
is we shouldn't have system code depending on host endianness.
It compares host vs target endianness, to determine if a swap is needed. But the real
dependency is target endianness.
r~
