On 12/16/22 22:59, Alexander Graf wrote:
> Hi Claudio,
>
> If the PSCI implementation becomes TCG only, can we also move to a tcg accel
> directory? It slowly gets super confusing to keep track of which files are
> supposed to be generic target code and which ones TCG specific>
> Alex
Hi Alex, Fabiano, Peter and all,
that was the plan but at the time of:
https://lore.kernel.org/all/20210416162824.25131-1-cfont...@suse.de/
Peter mentioned that HVF AArch64 might use that code too:
https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg00509.html
so from v2 to v3 the series changed to not move the code under tcg/ , expecting
HVF to be reusing that code "soon".
I see that your hvf code in hvf/ implements psci, is there some plan to reuse
pieces from the tcg implementation now?
Ciao,
Claudio
>
>> Am 16.12.2022 um 22:37 schrieb Fabiano Rosas <faro...@suse.de>:
>>
>> From: Claudio Fontana <cfont...@suse.de>
>>
>> Signed-off-by: Claudio Fontana <cfont...@suse.de>
>> Cc: Alexander Graf <ag...@csgraf.de>
>> Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
>> Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
>> Signed-off-by: Fabiano Rosas <faro...@suse.de>
>> ---
>> Originally from:
>> [RFC v14 09/80] target/arm: only build psci for TCG
>> https://lore.kernel.org/r/20210416162824.25131-10-cfont...@suse.de
>> ---
>> target/arm/meson.build | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/target/arm/meson.build b/target/arm/meson.build
>> index 87e911b27f..26e425418f 100644
>> --- a/target/arm/meson.build
>> +++ b/target/arm/meson.build
>> @@ -61,10 +61,13 @@ arm_softmmu_ss.add(files(
>> 'arm-powerctl.c',
>> 'machine.c',
>> 'monitor.c',
>> - 'psci.c',
>> 'ptw.c',
>> ))
>>
>> +arm_softmmu_ss.add(when: 'CONFIG_TCG', if_true: files(
>> + 'psci.c',
>> +))
>> +
>> subdir('hvf')
>>
>> target_arch += {'arm': arm_ss}
>> --
>> 2.35.3
>>
