On 1/10/23 18:19, Eric Auger wrote:
Hi Paolo,

On 1/10/23 17:02, Paolo Bonzini wrote:
From: Eric Auger <eric.au...@redhat.com>

To avoid compilation errors when -Werror=maybe-uninitialized is used,
replace 'case 3' by 'default'.

Otherwise we get:

../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’:
../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
    2495 |     d->Q(3) = r3;
         |     ~~~~~~~~^~~~
../target/i386/ops_sse.h:2494:13: error: ‘r2’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
    2494 |     d->Q(2) = r2;
         |     ~~~~~~~~^~~~
../target/i386/ops_sse.h:2493:13: error: ‘r1’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
    2493 |     d->Q(1) = r1;
         |     ~~~~~~~~^~~~
../target/i386/ops_sse.h:2492:13: error: ‘r0’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
    2492 |     d->Q(0) = r0;
         |     ~~~~~~~~^~~~

Signed-off-by: Eric Auger <eric.au...@redhat.com>
Suggested-by: Stefan Weil <s...@weilnetz.de>
Fixes: 790684776861 ("target/i386: reimplement 0x0f 0x3a, add AVX")
Message-Id: <20221221163652.1239362-1-eric.au...@redhat.com>
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>

you pulled v1 but there were additional comments afterwards and last
iteration was:
https://lore.kernel.org/all/20221222140158.1260748-1-eric.au...@redhat.com/

Ok, since I have to respin I will replace.  Thanks!

Paolo


Reply via email to