On Fri, 3 Mar 2023 at 20:59, Fabiano Rosas <faro...@suse.de> wrote: > > Peter Maydell <peter.mayd...@linaro.org> writes: > > > On Tue, 28 Feb 2023 at 19:28, Fabiano Rosas <faro...@suse.de> wrote: > >> > >> The migration tests are currently broken for an aarch64 host because > >> the tests pass no 'machine' and 'cpu' options on the QEMU command > >> line. > >> > >> Add a separate class to each architecture so that we can specify > >> 'machine' and 'cpu' options instead of relying on defaults. > >> > >> Add a skip decorator to keep the current behavior of only running > >> migration tests when the qemu target matches the host architecture. > > > > I still don't understand this patch. Don't we run the > > migration-test on all hosts already? David ? > > > > We run on all hosts but for each host we only take the QEMU binary that > matches the host architecture. So if you want to test aarch64 migration, > you need an aarch64 host. > > If you run on an x86_64 host (without this patch): > $ ../configure #all targets > $ make check-avocado AVOCADO_TESTS=../tests/avocado/migration.py > > You'll see: > > (1/3) ... migration.py:Migration.test_migration_with_tcp_localhost: PASS > (0.21 s) > (2/3) ... migration.py:Migration.test_migration_with_unix: PASS (0.18 s) > (3/3) ... migration.py:Migration.test_migration_with_exec: PASS (0.21 s) > > All three tests ran using qemu-system-x86_64. > > The issue I'm trying to solve is that when run on a aarch64 host, the > test will fail because (being generic) it doesn't pass the '-machine > virt' option and there is no architecture-specific information in it at > all.
But my point is that we already CI on aarch64 hosts, so what is happening there that means the test doesn't fail already ? -- PMM
