Paolo Bonzini <pbonz...@redhat.com> writes:
> On 5/3/23 11:12, Alex Bennée wrote: >> From: Fabiano Rosas <faro...@suse.de> >> The 'virt' machine uses virtio-net-pci as a fallback when no other >> network driver has been selected via command line. Select VIRTIO_NET >> and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n >> (due to e.g. --without-default-devices): >> $ ./qemu-system-aarch64 -M virt -accel tcg -cpu max >> qemu-system-aarch64: Unsupported NIC model: virtio-net-pci > > With respect to patches 5-17, very few devices need to be present when > configuring --without-default-devices, and thus need to be "select"ed > by Kconfig. You should select a device only if you cannot even start > the machine without --nodefaults. Which is the case here right? We could skip tests that explicitly instantiate a device but these are tests failing with default devices the machine tries to instantiate. > Anything else should be added by hand to configs/ if you use > --nodefaults. In particular, failures of "make check" when configured > --without-default-devices are *test* bugs, not configuration bugs. > > I didn't check if _all_ of the patches in this set should be dropped, > but most probably do. -- Alex Bennée Virtualisation Tech Lead @ Linaro
