Richard Henderson <richard.hender...@linaro.org> writes: > On 5/11/23 04:17, Markus Armbruster wrote: >> Fixes: 3e32dca3f0d1 (qapi: Rewrite parsing of doc comment section symbols >> and tags) >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> scripts/qapi/parser.py | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py >> index 4923a59d60..9315412ab2 100644 >> --- a/scripts/qapi/parser.py >> +++ b/scripts/qapi/parser.py >> @@ -563,11 +563,11 @@ def end_comment(self) -> None: >> self._switch_section(QAPIDoc.NullSection(self._parser)) >> @staticmethod >> - def _match_at_name_colon(string: str) -> re.Match: >> + def _match_at_name_colon(string: str) -> Optional[re.Match[str]]: >> return re.match(r'@([^:]*): *', string) >> @staticmethod >> - def _match_section_tag(string: str) -> re.Match: >> + def _match_section_tag(string: str) -> Optional[re.Match[str]]: >> return re.match(r'(Returns|Since|Notes?|Examples?|TODO): *', >> string) >> def _append_body_line(self, line: str) -> None: > > Doesn't work: > > https://gitlab.com/qemu-project/qemu/-/jobs/4289613692#L574 > > File "/builds/qemu-project/qemu/scripts/qapi/parser.py", line 566, in > QAPIDoc > def _match_at_name_colon(string: str) -> Optional[re.Match[str]]: > TypeError: 'type' object is not subscriptable
Life's too short for wrestling with such pigs. Unless John has better ideas, I'll *remove* these return type annotations. Maybe these pigs will behave after John's Python venv work lands.
