On Wed, Feb 08, 2012 at 01:45:15PM +0530, Aneesh Kumar K.V wrote: > On Tue, 7 Feb 2012 14:44:05 -0600, Meador Inge <mead...@codesourcery.com> > wrote: > > There have been reports [1, 2] where folks have had issues building > > VirtFS and the virtio backend on older systems. I personally saw > > problems due to the use of features (struct statfs f_frsize field, > > fdopendir, O_NOATIME) in this code that are not available on much older > > Linux systems. Given, the system I ran into this on is ancient (RH8 > > sysroot), > > but I still need to build QEMU on it nonetheless.
[snip] > I like the patch because it help to get qemu build on platforms where > the build failures are only due to virtfs. VirtFS do depend on some of > the recent linux APIs, so sometime we do break build on old Linux > distros. Allowing build to be disabled is a fine goal in itself. I think someone should still fix the code to be more portable though. f_frsize is a non-standardized field in 'struct stat', so its usage should be made conditional. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|