On 6/6/23 07:12, Philippe Mathieu-Daudé wrote:
Since commit 139c1837db ("meson: rename included C source files to .c.inc"), QEMU standard procedure for included C files is to use *.c.inc.Besides, since commit 6a0057aa22 ("docs/devel: make a statement about includes") this is documented as the Coding Style: If you do use template header files they should be named with the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are being included for expansion. Therefore rename the included templates as '.h.inc'. Signed-off-by: Philippe Mathieu-Daudé<phi...@linaro.org> --- target/i386/helper.h | 6 +++--- target/i386/{ops_sse_header.h => ops_sse_header.h.inc} | 0 ...hift_helper_template.h => shift_helper_template.h.inc} | 0 .../{cc_helper_template.h => cc_helper_template.h.inc} | 0 target/i386/tcg/cc_helper.c | 8 ++++---- target/i386/tcg/int_helper.c | 8 ++++---- 6 files changed, 11 insertions(+), 11 deletions(-) rename target/i386/{ops_sse_header.h => ops_sse_header.h.inc} (100%) rename target/i386/{shift_helper_template.h => shift_helper_template.h.inc} (100%) rename target/i386/tcg/{cc_helper_template.h => cc_helper_template.h.inc} (100%)
Move to tcg/ at the same time? Otherwise, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
