On 6/6/23 16:43, Richard Henderson wrote:
On 6/6/23 07:12, Philippe Mathieu-Daudé wrote:Since commit 139c1837db ("meson: rename included C source files to .c.inc"), QEMU standard procedure for included C files is to use *.c.inc.Besides, since commit 6a0057aa22 ("docs/devel: make a statement about includes") this is documented as the Coding Style: If you do use template header files they should be named with the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are being included for expansion. Therefore rename the included 'helper.h' as 'helper.h.inc' for all targets (updating the documentation). Suggested-by: Richard Henderson<richard.hender...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé<phi...@linaro.org> ---A bulk patch like this isn't ideal.
Unfortunately these headers (declaring HELPER_H path) are used by all targets: include/exec/helper-gen.h include/exec/helper-proto.h So this has to be bulk.
Targets that have a tcg/ subdir should have helper.h.inc moved into there.
OK.
At the end, include/exec/helper-gen.h and include/exec/helper-proto.h become unused and go away.
Ah, you are suggesting to first inline these helpers in each target, then move. Hmm OK I'll try.
