Peter Xu <pet...@redhat.com> wrote: > On Wed, Jun 21, 2023 at 09:38:08PM +0200, Juan Quintela wrote: >> Peter Xu <pet...@redhat.com> wrote: >> > On Fri, Jun 09, 2023 at 12:49:13AM +0200, Juan Quintela wrote: >> >> It failed on aarch64 tcg, lets see if that is still the case. >> >> >> >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> > >> > According to the history: >> > >> > https://lore.kernel.org/all/20190305180635.GA3803@work-vm/ >> > >> > It's never enabled, and not sure whether Yury followed it up. Juan: have >> > you tried it out on aarch64 before enabling it again? I assume we rely on >> > the previous patch but that doesn't even sound like aarch64 specific. I >> > worry it'll just keep failing on aarch64.
>> On multifd+cancel. >> >> I have no been able to ever get ignore_shared to fail on my machine. >> But I didn't tested aarch64 TCG in the past so hard, and in x86_64 it >> has always worked for me. > > Thanks a lot, Juan. > > Do you mean master is broken with QEMU_TEST_FLAKY_TESTS=1? And after the > whole series applied we cannot trigger issue in the few hours test even > with it? > > Shall we wait for another 1-2 days to see whether Yury would comment > (before you repost)? Otherwise I agree if it survives your few-hours test > we should give it a try - at least according to Dave's comment before it > was failing easily, but it is not now on the test bed. > > Maybe it's still just hidden, but in that case I also agree enabling it in > the repo is the simplest way to reproduce the failure again, if we still > ever want to enable it one day.. Sending v2. In that serie both re-enablement of multifd+cancel and ingnore_shared are the last two patches. So I am going to wait until all other patches are in and that the people that complained the most: Peter Maydell, Daniel and Thomas say/test on their cases. Hint, Hint. Later, Juan.
