On 6/21/2023 4:00 PM, Peter Xu wrote: > On Wed, Jun 21, 2023 at 03:39:44PM -0400, Steven Sistare wrote: >>>> - jmp mainloop >>>> + # should this test suspend? >>>> + mov (suspend_me),%eax >>>> + cmp $0,%eax >>>> + je mainloop >>>> + >>>> + # are we waking after suspend? do not suspend again. >>>> + mov $suspended,%eax >>> >>> So IIUC then it'll use 4 bytes over 100MB range which means we need at >>> least 100MB+4bytes.. not obvious for a HIGH_ADDR definition to me.. >>> >>> Could we just define a variable inside the section like suspend_me? >> >> No, because modifications to this memory backing the boot block are not >> copied to the destination. The dest reads a clean copy of the boot block >> from disk, as specified by the qemu command line arguments. > > Oh okay, can we use HIGH_ADDR-4, then? I just still think it'll be nice if > we can keep HIGH_ADDR the high bar of the whole range.
Sure. I'll use LOW_ADDR + 4, and add a comment. - Steve
