Hi On Wed, Jun 28, 2023 at 12:32 AM Dongwon Kim <dongwon....@intel.com> wrote:
> Surface is replaced with a place holder whenever the surface res > is unreferenced by the guest message. With this logic, there is > very frequent switching between guest display and the place holder > image, which is looking like a flickering display if the guest driver > is designed to unref the current scanout resource before sending out > a new scanout resource. So it is better to leave the current scanout > image until there is a new one flushed by the guest. > > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Marc-André Lureau <marcandre.lur...@redhat.com> > Cc: Vivek Kasireddy <vivek.kasire...@intel.com> > Signed-off-by: Dongwon Kim <dongwon....@intel.com> > Why is the driver not setting a different scanout before destroying the resource? I think it's wrong to not replace the surface, as the associated scanout resource may be destroyed or explicitly disabled for various purposes, and we don't want to display garbage either. --- > hw/display/virtio-gpu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c > index 66cddd94d9..9d3e922c8f 100644 > --- a/hw/display/virtio-gpu.c > +++ b/hw/display/virtio-gpu.c > @@ -387,7 +387,6 @@ static void virtio_gpu_disable_scanout(VirtIOGPU *g, > int scanout_id) > res->scanout_bitmask &= ~(1 << scanout_id); > } > > - dpy_gfx_replace_surface(scanout->con, NULL); > scanout->resource_id = 0; > scanout->ds = NULL; > scanout->width = 0; > -- > 2.34.1 > > > -- Marc-André Lureau
