On Fri, 17 Feb 2012 12:44:28 +0100 Markus Armbruster <arm...@redhat.com> wrote:
> >> I figure Luiz's patch works. But maybe it could be simplified some by > >> replacing bdrv_dev_change_media_cb() by a "open/close tray" callback > >> that returns whether it moved. bdrv_dev_change_media_cb() would then > >> simply open the tray, emit event if it moved, close the tray, emit event > >> if it moved. > > > > Yes, I had the same impression after reading the first few paragraphs of > > your analysis (which looks right to me). > > If I understand Luiz correctly, he'd like to do that in a follow-up > patch. Yes, but as I said I'm not completely sure what's the best thing to do here, and this may take some time, but I'll do it.