On Wed, Sep 6, 2023 at 4:43 PM Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
> On 6/9/23 16:33, Albert Esteve wrote: > > > I note you ignored my comment regarding adding a 'Error **' > argument in > > the previous version: > > > https://lore.kernel.org/qemu-devel/911eef0c-d04f-2fcf-e78b-2475cd7af...@linaro.org/ > < > https://lore.kernel.org/qemu-devel/911eef0c-d04f-2fcf-e78b-2475cd7af...@linaro.org/ > > > > > > Sorry I missed those comments somehow :/ > > Ah, I see. > > > I'll check them and resend. > > You can also object to them, explaining why this isn't really > useful, if you think so. But first read the big comment in > include/qapi/error.h. > > Sure, I understand. So far I tend to trust the judgement of the more experienced Qemu developers over my own, but if I wouldn't agree with what is suggested I would object :) So: - Regarding the two functions with the same, seems to be solved with the squash before, and it was probably causing the compile error to begin with, so one less thing to worry about! - Regarding splitting the commit, sure, no problem. I'll ensure they do compile separately. - Regarding the error, I read the long comment in the error file and checked surrounding code. I think you are right and will be better propagating the error. And I think I would address all your comments with that! Thanks for the feedback! > Thanks, > > Phil. > >
