On 6/9/23 18:18, Albert Esteve wrote:
So:
- Regarding the two functions with the same, seems to be solved with
the squash before,
and it was probably causing the compile error to begin with, so
one less thing to worry about!
- Regarding splitting the commit, sure, no problem. I'll ensure they
do compile separately.
- Regarding the error, I read the long comment in the error file and
checked surrounding code. I think
you are right and will be better propagating the error.
But I think I will omit the Error propagation for
`vhost_user_backend_handle_shared_object_lookup`.
In this function returning an error code does not necessarily mean that
we should log an error.
So if we pass the local_err from the backend_read function to the
handler, we cannot be sure
when we should actually print the log.
`vhost_backend_handle_iotlb_msg` has the same issue and does not
propagate the error either,
relies solely on `error_report` calls.
Therefore, I will propagate it for `vhost_user_send_resp` and
`vhost_user_backend_send_dmabuf_fd` only.
Sounds good!
