08.09.2023 20:16, Kevin Wolf:
Am 08.09.2023 um 18:11 hat Philippe Mathieu-Daudé geschrieben:
Hi Kevin,
On 8/9/23 17:01, Kevin Wolf wrote:
Am 07.09.2023 um 17:44 hat Stefan Hajnoczi geschrieben:
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
Something in this has broken the build for me, it seems to be the
linux-user binary that doesn't link any more:
/usr/bin/ld: libqemu-x86_64-linux-user.fa.p/target_i386_cpu.c.o: in
function `cpu_x86_cpuid':
/home/kwolf/source/qemu/build-clang/../target/i386/cpu.c:6180: undefined
reference to `kvm_arch_get_supported_cpuid'
My patches. I can not reproduce so far,
Hm, ok. I can try to bisect it further then.
case 7:
/* Structured Extended Feature Flags Enumeration Leaf */
if (count == 0) {
...
if ((*ebx & CPUID_7_0_EBX_SGX) &&
(!kvm_enabled() ||
!(kvm_arch_get_supported_cpuid(cs->kvm_state, 0x7, 0, R_EBX) &
CPUID_7_0_EBX_SGX))) {
*ebx &= ~CPUID_7_0_EBX_SGX;
}
if ((*ecx & CPUID_7_0_ECX_SGX_LC) &&
(!(*ebx & CPUID_7_0_EBX_SGX) || !kvm_enabled() ||
!(kvm_arch_get_supported_cpuid(cs->kvm_state, 0x7, 0, R_ECX) &
CPUID_7_0_ECX_SGX_LC))) {
*ecx &= ~CPUID_7_0_ECX_SGX_LC;
}
It is most likely patch "target/i386: Remove unused KVM stubs" which removed
kvm_arch_get_supported_cpuid(). Apparently clang isn't smart enough to
eliminate
call to this function?
/mjt