On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote: > Oh dear, where to start. There's so much wrong, and in pretty obvious > ways. This code should never have passed review. I'm refraining from > saying more; see the commit messages instead. > > Issues remaining after this series include: > > * Terrible error messages > > * Some error message cascades remain > > * There is no written contract for QEMUFileHooks, and the > responsibility for reporting errors is unclear
Even being removed.. because no one is really extending that.. https://lore.kernel.org/all/20230509120700.78359-1-quint...@redhat.com/#t > > * There seem to be no tests whatsoever I always see rdma as "odd fixes" stage.. for a long time. But maybe I was wrong. Copying Zhijian for status of rdma; Zhijian, I saw that you just replied to the hwpoison issue. Maybe we should have one entry for rdma too, just like colo? Thanks, -- Peter Xu
