Re: [PATCH RFC V2 09/37] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

[Gavin Shan]

On 9/26/23 20:04, Salil Mehta wrote:

CPU ctrl-dev MMIO region length could be used in ACPI GED (common ACPI code
across architectures) and various other architecture specific places. To make
these code places independent of compilation order, ACPI_CPU_HOTPLUG_REG_LEN
macro should be moved to a header file.

Signed-off-by: Salil Mehta <salil.me...@huawei.com>
---
  hw/acpi/cpu.c                 | 2 +-
  include/hw/acpi/cpu_hotplug.h | 2 ++
  2 files changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Gavin Shan <gs...@redhat.com>

diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c
index 19c154d78f..45defdc0e2 100644
--- a/hw/acpi/cpu.c
+++ b/hw/acpi/cpu.c
@@ -1,12 +1,12 @@
  #include "qemu/osdep.h"
  #include "migration/vmstate.h"
  #include "hw/acpi/cpu.h"
+#include "hw/acpi/cpu_hotplug.h"
  #include "qapi/error.h"
  #include "qapi/qapi-events-acpi.h"
  #include "trace.h"
  #include "sysemu/numa.h"

-#define ACPI_CPU_HOTPLUG_REG_LEN 12

  #define ACPI_CPU_SELECTOR_OFFSET_WR 0
  #define ACPI_CPU_FLAGS_OFFSET_RW 4
  #define ACPI_CPU_CMD_OFFSET_WR 5
diff --git a/include/hw/acpi/cpu_hotplug.h b/include/hw/acpi/cpu_hotplug.h
index 3b932abbbb..48b291e45e 100644
--- a/include/hw/acpi/cpu_hotplug.h
+++ b/include/hw/acpi/cpu_hotplug.h
@@ -19,6 +19,8 @@
  #include "hw/hotplug.h"
  #include "hw/acpi/cpu.h"

+#define ACPI_CPU_HOTPLUG_REG_LEN 12

+
  typedef struct AcpiCpuHotplug {
      Object *device;
      MemoryRegion io;