Hi New attempt based on 3928 revision. - src/CDeviceGPSD.cpp fixed - 3rdparty/SerialPort removed if Qt version >= 5.1 - 3rdparty/tzone removed if Qt version > 5.2 - 3rdparty/QMKToolBox dependence removed in Qt5 build, but it will not be successfully linked if MIKROKOPTER enabled, but you mentioned that it has obsoleted, so... - added Win32/OS X fixes from your Qt5 branch, but i am unable to test on this platforms - CMAKE_PREFIX_PATH is environment variable, so you may set it in your environment, or i don't understand what you have meant exactly
Lebedev Dmitry 2014-02-24 22:49 GMT+04:00 Oliver Eichler <[email protected]>: > Hi > > > > thanks for the patch. I don't know if you are aware of the branch: > > > > > https://sourceforge.net/p/qlandkartegt/code/HEAD/tree/QLandkarteGT/branches/Qt5/ > > > > That's an attempt to port QLGT to QT5 a few month ago. We tried QT5.1 at > this time and there where still too many peculiarities to go on. However > this branch has fixes for Win32 and OS X. I would like to ask you to look > at this branch and to add the fixes to your patch. Is that possible? > > > > Additionally I noticed: > > > > * I had to add the path to the Qt cmake files. Something like: > > > > set(CMAKE_PREFIX_PATH /opt/Qt/5.2.0/gcc_64/lib/cmake/) > > > > to make cmake find the findModuleXXX scripts for Qt5 > > > > * src/CDeviceGPSD.cpp failed because of #include <QtWidgets> missing. > > > > * add_subdirectory(3rdparty/SerialPort) and > > add_subdirectory(3rdparty/QMKToolBox) can be skipped. The first is now > part of Qt5 (needs some fixes in the code) the later is obsolete. > > > > * add_subdirectory(3rdparty/tzone) probably can be replaced by QTimeZone. > If that works it is the biggest benefit from Qt5 as tzone has bugs for some > timezones, e.g. in Russia. > > > > > > It would be fine if you could fix these topics. I like your patch as you > started to add ifdefs to compile for Qt4 and 5. That makes it interesting > to add it to the main branch and thus part of further releases. > > > > Oliver > > >
qlandkartegt_r3928_qt5_port.patch.xz
Description: application/xz
------------------------------------------------------------------------------
_______________________________________________ Qlandkartegt-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qlandkartegt-users
