Re: [qmailadmin] max forwards

[Tom Collins]

On Jun 12, 2004, at 10:05 AM, qmailadmin user wrote:
In user.c #916
change
    while( tmpstr != NULL && count < 5) {
to
    while( tmpstr != NULL && count < MAX_FORWARDS) {
IMHO this should make that constant easier for do-it-yourselfers to 
find and modify.
This is a good idea, but we would need to watch out for buffer 
overflows.  I think that the code assumes it can fit the entire lists 
of forwards into an arbitrarily-sized buffer.  It would be better to 
have the size of the buffer based on MAX_FORWARDS * (MAX_ADDRESS_SIZE + 
1).

--
Tom Collins  -  [EMAIL PROTECTED]
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/