Hi Dalmazio,
many thanks for the fixes! I've just committed them to the legacy_0_7_x
branch (Revision #14912)
cheers,
Alex
Dalmazio Brisinda wrote:
> Aside from my previous query, looks like I might have another bug fix. This
> bug fix allows the event "loadComplete" to fire. In the member function
> imageOnComplete() the following code:
>
> if (this._processedImages == this._listSize) {
> this.dispatchEvent(new qx.event.type.Event("loadComplete"), true);
> }
>
> should be replaced with:
>
> if (this._processedImages == this._list.length) {
> this.dispatchEvent(new qx.event.type.Event("loadComplete"), true);
> }
>
> Since the this._listSize member variable is not kept up-to-date with the
> actual size of the list. In any case, it's probably better to just get the
> actual size of the list when needed from the list itself.
>
> Also, the following lines needs to be added to the end of the following
> member functions so the number of processed images are kept in sync when
> images are deleted:
>
> removeAll : function() {
> ...
> this._processedImages = 0; // add this
> }
>
> and
>
> deleteByPosition : function(vPos) {
> ...
> this._processedImages--; // add this
> }
>
> This works for me when adding images (even after deleting images), the
> "loadComplete" now fires. But please confirm in case I've missed some
> rationale behind the original logic.
>
> Best,
> Dalmazio
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
