Hi Derrell,

Stefan Volbers wrote:
> Works beautifully at first sight.
> Ain't tested the new error mechanism though, will try in the next days.

Well, there is a detail missing.
Seems like you moved this line

$error->SetId($jsonInput->id);

to the final (error) output at the end of the script. Consequently it 
won't get called in case e.g. a PHP Warning is happening in the target 
RPC class, which causes the JsonRpcErrorHandler to jump in and exit 
without setting the id.
Qooxdoo in turn issues a warning about the RPC id not being identical.

I resolved this temporarily by returning the SetId to line 609 or so, 
just where it used to be. In case of an error, $output would be a clone 
of $error anyway, thus containing the right id property.
Maybe your idea was to keep the id out of the backend classes, so I 
guess you will come up with an improved fix for this small issue.

Looking forward to reading your comment,

Stefan

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to