OK just had a chance to look at the code and wanted to point out some things that might improve it. (This isn't meant to be critisism, just the spirit of sharing).
I noticed you used a menu bar, surely this has a lot of over head? You could simply create a container with a HBox layout and set the decorator to menubar. Or better yet, if you are willing to drop the custom icon support you could just have a single atom for the whole bar. Or to make things simpler, you could change the whole bar for a toggle button and then provide a custom decorator that inherites from menubar but changes the icon based on the state. These are just some ideas I had, if you are interested I could make the change locally and send you it so you can see exactly what I mean. Matt panyasan wrote: > Hello qooxdooers, > > here comes another new contribution: a simple collapsable panel: > > https://qooxdoo-contrib.svn.sourceforge.net/svnroot/qooxdoo-contrib/trunk/qooxdoo-contrib/collapsablePanel/trunk/ > > Demo is at > > http://m53s12.vlinux.de/cboulanger/collapsablepanel/build/ > > here is a Screenshot: > > http://n2.nabble.com/file/n3791440/Bild%2B2.png > > It is doing what it is supposed to do, however, there are a couple of things > that could be improved: > > - Animation: I have tried to use qx.fx to collapse the panels with an > animation, but have failed miserably. The attempt is still in the code > (commented out), so if an animation specialist wants to join in, this would > be very much appreciated. > > - Flexible resizing: In the demo, the panel container is a Scroll container, > so if you expand all panels, the used space is just increased. Ideally, > there should be a mode where opening one panel would decrease the size of > all other opened panels proportionally. > > To end, I want to praise the qooxdoo dev's for making adding a contribution > a snap with "create-application -t contribution". It's really easy now. > > Best, > > Christian ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
