Hi Matt,
Noggin182 wrote: > > OK just had a chance to look at the code and wanted to point out some > things that might improve it. > (This isn't meant to be critisism, just the spirit of sharing). > > I noticed you used a menu bar, surely this has a lot of over head? You > could simply create a container with a HBox layout and set the decorator > to menubar. Or better yet, if you are willing to drop the custom icon > support you could just have a single atom for the whole bar. > Or to make things simpler, you could change the whole bar for a toggle > button and then provide a custom decorator that inherites from menubar > but changes the icon based on the state. > > These are just some ideas I had, if you are interested I could make the > change locally and send you it so you can see exactly what I mean. > No problem at all, on the contrary, you are welcome to improve the whole thing in any way you want - that's the whole point of qooxdoo-contrib, isn't it ;-) Seriously, I am very happy about changes in the code as long as in the end, the widget works as expected. I am not very familiar with theming or decorators so please go forward and commit ! That's the open source spirit! Christian -- View this message in context: http://n2.nabble.com/New-Contribution-Collapsable-Panel-tp3791440p3793442.html Sent from the qooxdoo mailing list archive at Nabble.com. ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
