Hi Aidan,
I was in a hurry and when I was checking few hours a go so when I started on
developing this i felt there's something wrong.
On Sun, Jul 27, 2008 at 8:24 AM, lahiru gunathilake <[EMAIL PROTECTED]>wrote:
>
> Hi Aidan,
>
> First thanks for the reply.
> On Sun, Jul 27, 2008 at 1:55 AM, Aidan Skinner <[EMAIL PROTECTED]> wrote:
>
>> On Sat, Jul 26, 2008 at 8:50 AM, lahiru gunathilake <[EMAIL PROTECTED]>
>> wrote:
>>
>> > Do you thing this is useful because you said info command normally
>> display
>> > all the information of a single object but here when user run the
>> command
>> > without -n option there are so many queue objects.So if you want me to
>> avoid
>> > listing so many objects I can do that....
>>
>> I think object name should be mandatory, that way you'll only get one.
>> Well, you would if it was limited to one virtual host. Which I think
>> should probably be kind of like database context. Maybe something like
>> this:
>>
>> [EMAIL PROTECTED]:~/hacking/lahirugsoc[master]/$ bin/qpid-cli
>>
>> :/home/aidan/hacking/lahirugsoc/lib/jline-0.9.94.jar:/home/aidan/hacking/lahirugsoc/lib/junit-4.4.jar:/home/aidan/hacking/lahirugsoc/build/main/classes/
>> Connecting to localhost Qpid java broker...
>> qpid-admin-$ virtualhost list
>> [.. list of vhosts..]
>> qpid-admin-$ virtualhost use development
>> Using virtualhost development
>> qpid-admin-$ queue list
>> [... list of queues in development virtualhost ...]
>>
>> The other option would be to specify it to list. Maybe something like:
>>
>> queue list -v <vhost> -n <name>
>
> I will implement like this.
>
I think we want to get a single object with info command so this apply for
info command not with list command.
>
>
>>
>> or alternatively:
>>
>> queue list <vhost>:<name>
>>
>> as well as
>>
>> queue list <name>
>>
>> The info command should probably work in the same way. I found a
>> couple of bugs while testing, which I'll file in Google code tomorrow,
>> there's an NPE when you 'list' and 'queue info ping' returns all the
>> queues (it shouldn't need the -n if there's only one argument),
>> nothing major. It looks good :)
>
> ok
>
Why don't we use a standard way to give arguments, with list we give
arguments with minuse("-") sign so why don't we use the same with info
command, I think we have to use -n to specify the object name with info
whereas we use the same thing with list which leads to less confusion with
users. And from the beginning I started developing commands in the normal
way with minus sign and argument value.
What do you think ?
Lahiru
>
>
> Thanks in advance
>
> Regards
> Lahiru
>
>>
>>
>> - Aidan
>> --
>> Apache Qpid - World Domination through Advanced Message Queueing
>> http://cwiki.apache.org/qpid
>>
>
>