On Thu, Aug 14, 2008 at 3:21 PM, Andrew Stitcher <[EMAIL PROTECTED]> wrote:
> On Thu, 2008-08-14 at 15:16 +0100, Aidan Skinner wrote: >> I've raised an INFRA ticket to get a 'Ready for review' status in >> between 'In Progress' and 'Resolved'. >> >> I'd quite like to move the Java client and broker to a >> review-then-commit model, with any one committer other than the author >> being sufficent. > > 1. I assume this is intended for changes to released code. I was kinda thinking for all the Java stack actually. We don't do much that is entirely new development. > 2. Without actually commiting the change the reviewer doesn't easily get > to see the change, and no I don't consider attached patches to be > adequate with svn. Why not? Is it just the rebasing problem? Personally I'd prefer small branches that can be reviewed then merged, but I don't think that's realistic until and unless we move to $DVCS[1]. - Aidan [1] For $DVCS == git, as it is clearly superior to bzr and hg in crucial ways -- Apache Qpid - World Domination through Advanced Message Queueing http://cwiki.apache.org/qpid "Nine-tenths of wisdom consists in being wise in time." - Theodore Roosevelt
