> I do agree that code is always better when it's reviewed, but I think
> anything like this would have to be enforced (at least somewhat) for
> this to have value.
>

>From the Java side we have been attempting to put in place reviews
before code is considered eligible for release.  Up until now we have
been doing this in a weekly review call...  As the volume of change
increases the feasibility of this decreases - so moving to a
distributed review model works better.  certainly at release time I
would expect us to review all JIRAs to make sure their code was
reviewed.  Also I would be reviewing all code committed without a JIRA
and asking for a JIRA to be created explaining the change...  however
that is purely on the Java side... I don't believe there has been a
similar process on the C++ side of the house...

-- Rob

Reply via email to