Marnie McCormack wrote:
Hi,
I think that we should discuss options here i.e. we have a defined process
for ensuring our code quality. If this is not working then we should agree
the outcome i.e. if you don't have an item reviewed within x weeks then the
commit is reverted from trunk ? (For the Java items, we should not be
releasing anything not reviewed iiuc our approach here.)
Drastic I know, but it's not cricket imho to have agreed to adopt an
approach and then have Aidan be the policeman for the project.
Thoughts ?
I don't think this is feasible. Commits that are on the order of weeks
old aren't trivially revertible. The work to disentangle the commit from
any subsequent modifications could easily be more work than simply doing
the review, and in many cases would itself constitute a change requiring
review.
--Rafael
