I can't say I agree with this patch, even though it would represent a
less significant change and satisfy more parties.. it would also make it
more likely for both terms to be used throughout the code, decreasing
readability and increasing the confusion (now the uninitiated reviewer
has to not only find out what DECLINED means, but also what NEXT means).
It seems better to tell people what to use and try to stick with it --
even if that's sticking with DECLINED -- and only keep a second label
around if it's necessary for backward compatibility.
-Jared
David Nicol wrote:
$ svn diff
Index: Qpsmtpd/Constants.pm
===================================================================
--- Qpsmtpd/Constants.pm (revision 967)
+++ Qpsmtpd/Constants.pm (working copy)
@@ -24,6 +24,7 @@
DENY_DISCONNECT => 903, # 550 + disconnect
DENYSOFT_DISCONNECT => 904, # 450 + disconnect
DECLINED => 909,
+ NEXT => 909, # happier alias for DECLINED
DONE => 910,
CONTINUATION => 911, # deprecated - use YIELD
YIELD => 911,
