Matt Sergeant wrote: > > On Wed, 14 Jan 2009 09:10:14 -0600, Jared Johnson wrote: > > Hi, > > > > Is there any interest in patches to conform current QP code to line > > length and whitespace standards? > > > > 1. I notice that most of the codebase uses 4-space indents, but I > > have seen some areas with 2-space indents and tab characters. > > The original codebase (Ask's code) was all 2 space indents. The newer > qpsmtpd coders all prefer 4 spaces, so we sort of overruled Ask (sorry > mate :)). There was a plan at some point to run everything through > perltidy to set 4 spaces everywhere, but nobody ever got around to > it.
Hey, I prefer 2 spaces too :) > > 2. It's been pointed out that it is preferred that lines are kept to > > 80 characters are less, but this is violated in a number of places. > > Meh, I'm not hardcore about this. Screens are bigger these days, or vim > displays stuff nicely anyway. I think it's a good overall rule, but if > you have a long string or something I don't have a problem violating > it. I like 80 -- but exceptions happen. We shouldn't have long strings in our codebase very often. > > Our organization conforms to similar coding guidelines WRT these > > issues and I would be happy to submit patches to cleanup up each of > > these areas if there's any desire. I would also suggest creating a > > 'coding guidelines' page on the wiki for this and any other style > > issues that are deemed useful to conform to. > > Think we should do this after the git migration is complete. Definitely not before.
