On Tue May 08, 2012 at 09:29:57 -0700, Robert Spier wrote: > > > > +use strict; > > +use warnings; > > + > > +use base 'Qpsmtpd::Plugin'; > > +use Qpsmtpd::Constants; > > + > > > > All of these except for use warnings come for free with any plugin. > They're not required here.
I have to say that if we're going to do a mass-shuffle in the near future to cleanup whitespace/POD/etc adding these lines in globally would be wonderful. Having all implicit modules included allows you to run plugin files through "perl -c" without false warnings. [FWIW I'd agree moving the code to a central location is good, moving it into ::Plugin is a bad plan.] Steve -- Debian GNU/Linux System Administration http://www.debian-administration.org/
