On May 18, 2012, at 9:33 AM, Charlie Brady wrote:
> I think the documentation of the reject option could be clearer. What
> value of the parameter should be used when first using this plugin? I
> think "reject 0".
Boolean means 0 or 1, but your point is well made. The documentation should be
clear for non-programmers, who may not be familiar with the term boolean. I
shall make amends.
I concur with 'reject 0' being the default. But previous versions of this
plugin had a default reject policy.
I happen to believe that every plugin should default to 'reject 0'. But the
more changes I make to plugin behaviors, the more resistant the gatekeepers are
to my commits.
Matt
> On Fri, 18 May 2012, Matt Simerson wrote:
>
>> added reject option
>> document the existence of the loglevel option
>> ---
>> plugins/check_basicheaders | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/plugins/check_basicheaders b/plugins/check_basicheaders
>> index 114867a..ef0e42d 100644
>> --- a/plugins/check_basicheaders
>> +++ b/plugins/check_basicheaders
>> @@ -24,6 +24,14 @@ unset, messages are not rejected based on the date.
>>
>> check_basicheaders [ days 3 ]
>>
>> +=head2 reject
>> +
>> +A boolean. Determines if the connection is denied or not. Use this option
>> +when first enabling the plugin, and then watch your logs to see what would
>> +have been rejected.
>> +
>> +Default policy is to reject.
>> +
>> =head2 reject_type
>>
>> Whether to issue a permanent or temporary rejection. The default is
>> permanent.
>> @@ -34,6 +42,10 @@ Switching to a temporary rejection is most useful when
>> testing the plugin. It
>> allows an administrator to watch for a test period and make sure no valid
>> mail
>> is getting rejected.
>>
>> +=head2 loglevel
>> +
>> +Adjust the quantity of logging for this plugin. See docs/logging.pod
>> +
>> =head1 AUTHOR
>>
>> 2004 - Written by Jim Winstead Jr.
>> @@ -67,6 +79,7 @@ sub hook_data_post {
>> my ($self, $transaction) = @_;
>>
>> my $deny = $self->{_args}{reject_type} eq 'temp' ? DENYSOFT : DENY;
>> + $deny = DECLINED if defined $self->{_args}{reject} && !
>> $self->{_args}{reject};
>>
>> if ( $transaction->data_size == 0 ) {
>> $self->log(LOGINFO, "fail: no data");
>>
