On Wed, Apr 15, 2015 at 9:58 AM, Mateusz Loskot <mate...@loskot.net> wrote:
> On 15 April 2015 at 08:46, André Hartmann <andre.hartm...@iseg-hv.de> > wrote: > >> For example, let's assume we start working on the contribution as > follows: > >> 1. Import current sources of our plugin into > wip/boostbuildprojectmanager > > > > To submit this first commit, it would be best all current developers > give a > > +1 review to show their acceptance that the code is merged to the Qt > > repositories. > > André, > > The issue here is, that I know the current code will be rejected straight > away > due to Qt(Creator)-incompatible coding conventions used. > So, we need to port to Qt coding style and we will be working on it as a > team. > It won't be rejected. Wip branches are exactly for that - submitting changes that are unacceptable under regular terms, while the final review will be done in a single squashed commit when the work on this branch is done. You should have access to +2 changes for this branch yourself. - Orgad
_______________________________________________ Qt-creator mailing list Qt-creator@qt-project.org http://lists.qt-project.org/mailman/listinfo/qt-creator
