This patch series has NO FUNCTIONAL IMPACT AT ALL, it just reformats the main build.xml to match the most prevalent style:
* 4 spaces indentation, * tabs expanded as spaces. Because I use vim, the first patch is an XML comment, recognized by vim, that will instruct it about the two hints above. All other patches are just style corrections. Patch 2 has the most impact, in fact, since it reworks the <echo> target invocation (and adds an extra "[echo]" output to the build process...). I also took the opportunity to replace all tabs by spaces, and remove unneeded spaces (at end of lines, removing extra empty lines, shrinking). Even though these are only cosmetic changes, I intend to base my future work on these patches. This future work will impact the build system greatly, provided that I get the approval for it. Future works are, in this order: * use ant's <macrodef> to simplify all generator.*xml* and qtjambi.typesystem* targets; (which, by the way, would be even more simple if I could use ant-contrib, but IANAL and therefore am not sure about license compatibilities. Comments?) * condition the build of juic (this is THE main obstacle today for users and packagers, since building juic requires compiled qt sources); * try to use ant's <macrodef> to replace some of the tasks defined by ant-qtjambi.jar; * separating the build steps (JNI, tools, Java code, ant libs...) into separate build files, which, ultimately, will make the build system more maintainable (at least from my point of view); * final cleanup step: have a .gitignore file that will allow to avoid having to invoke git clean -df after each build... Please consider applying! Francis Galiegue (3): build.xml: add vim directives build.xml: rework the help target build.xml: style unification build.xml | 739 +++++++++++++++++++++++++++++++------------------------------ 1 files changed, 370 insertions(+), 369 deletions(-) _______________________________________________ Qt-jambi-interest mailing list [email protected] http://lists.trolltech.com/mailman/listinfo/qt-jambi-interest
