On Thu, 25 Feb 2016, Lou Berger wrote:
Paul,
I think you and I are getting close to some agreeable text . At this point I
think it would be good to hear from others particularly from those who
contribute most significantly to the project at this time. See below for
specific responses.
Ack,
Okay. Although I think the maintainer's responsibility to prevent garbage
from being added to the base extends to this topic as well.
Sure, and I have done, where it's 100% clear. 100% clear would basically
be things like "adding a copyright string with no other modifications to
the file", given the bar to copyright is very low.
So the issue was that "Copyright" strings for modifications could cause
confusion about the scope, right?
Exactly!
How about we focus on that and just
say for modifications, it should be prefaced with "Portions:\n"?
I still think that the form in the document you pointed to, where the
copyright is qualified by a summary description of what the copyright
covers, is better.
The issue is at some point people either have to refer to the SCM data
(if still available) and/or to contact the people/organisations listed
in the copyright strings to really get the fine detail.
I just don't think we can get any useful level of detail into changelogs
with the strings. (and the SFLC document on maintaining those strings
was written before the wide-spread use of git I think / tail end of the
CVS days).
But that said,
A single line saying " Portions Copyright. ..", would be ok.
But with the proposed form:"
Portions:
Copyright ...."
I think the line break , with multiple lines eventually being added , would
still result in confusion overtime.
Ok, So that'd be something like (note also added a "by your
contribution" to the end of the first sentence added - as per SFLC you
usually shouldn't add these for others):
From 7c658567a36b6d31c640d36e828d52344ba33357 Mon Sep 17 00:00:00 2001
From: Paul Jakma <[email protected]>
Date: Tue, 26 Jan 2016 12:45:31 +0000
Subject: HACKING: Document how to add standard copyright claims to files
* (REQUIRED READING) Copyright claims may be documented in the standard way,
with a "Copyright ..." line near the beginning of the file.
diff --git a/HACKING.md b/HACKING.md
index 7a5d973..6c33bdb 100644
--- a/HACKING.md
+++ b/HACKING.md
@@ -50,6 +50,22 @@ be _explicitly_ stated with the contribution. A
"Signed-off-by" line is
_not_ sufficient. The "Signed-off-by" line is not used by the Quagga
project.
+You may document applicable copyright claims to files being modified or
+added by your contribution. The standard way is to add a string in the
+following format near the beginning of the file:
+
+ Copyright (C) <Year> <name of person/entity>[, optional contact details]
+
+When adding copyright claims for modifications to an existing file, please
+preface the claim with "Portions: " on a line before it and indent the
+"Copyright ..." string. If such a case already exists, add your indented
+claim immediately after. E.g.:
+
+ Portions:
+ Copyright (C) <Year> <Entity A> ....
+ Copyright (C) <Year> <Your details> ....
+
+
GUIDELINES FOR HACKING ON QUAGGA {#sec:guidelines}
================================
regards,
--
Paul Jakma [email protected] @pjakma Key ID: 64A2FF6A
Fortune:
What is it about so many mail system authors and lacking sense of humour.
- Alan Cox on linux-kernel
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
