Philippe,
On 6/9/2016 4:15 AM, Philippe Guibert wrote:
> On Wed, Jun 8, 2016 at 9:22 PM, Lou Berger <[email protected]> wrote:
>
> Hi Lou,
>>> * It seems the RD_TYPE_EOI type surfaced again (see
>>> http://patchwork.quagga.net/patch/1728/ ), whereas I don't see where it
>>> is used. Is there a need to keep this flag ?
>> This is used by the ethernet code, see below.
>>
> oh. It seems it is used decode_rd_type ? Would not it be better to set
> explicitly the value to RD_TYPE_EOI instead of 0xff00 ?
>
> --- a/bgpd/bgp_mplsvpn.c
> +++ b/bgpd/bgp_mplsvpn.c
> @@ -52,7 +52,7 @@ decode_rd_type (u_char *pnt)
> * VNC L2 stores LHI in lower byte, so mask it off
> */
> if ((v & 0xff00) == 0xff00)
> - v = 0xff00;
> + v = RD_TYPE_EOI;
> #endif
> return v;
> }
Good catch! I suspect this got changed internally when it was removed
from the first patch set and then not restored...
> [...]
>>> To sum up, with the current status, I would nack the patch.
>> Perhaps this would be a good discussion for the next monthly meeting.
> If you don't mind, I would prefer a followup with emails in order to
> archive the arguments so everyone can follow this thread. Always some
> people are missing into the calls.
No problem at all. I just figured it would be good to have a higher
bandwidth discussion channel to answer any questions that folks may
have.
> Moreover, can you provide a description of this Remote Forwarder
> Protocol (RFP) into an update of this patch serie? It is required for
> Quagga community to understand it.
Sure, as we said the RFP and VNC feature is aliened with the NVO3
architecture and
The NVE-NVA protocol used to communicate routing and Ethernet / Layer 2
(L2) forwarding information between NVAs and NVEs is referred to as the
Remote Forwarder Protocol (RFP). OpenFlow is an example RFP.
So from a conceptual standpoint draft-ietf-nvo3-nve-nva-cp-req is a good place
to start.
For a concrete example see
https://www.opennetworking.org/images/stories/downloads/sdn-resources/onf-specifications/openflow/openflow-spec-v1.3.0.pdf
We have an openflow RFP implementation in the works and once it is sufficiently
mature / stable, we'll submit it too.
Cheers,
Lou
> Thanks,
> Philippe
>
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
