On Fri, Jun 17, 2016 at 4:10 PM, Lou Berger <[email protected]> wrote:
Hello Lou, >> #if ENABLE_BGP_VNC >> if (v != RD_TYPE_VNC_ETH) >> v |= (u_int16_t) *pnt; >> #else >> v |= (u_int16_t) *pnt; >> #endif >> >> IMHO, I think this brings more clarity about the algorithm in place. > I considered this, but I hate duplicate code so came down on the other > side. But I was on the fence, so will make this change. > If i can bring an argument between the two writings. The clarity is brought by the extra spaces located just before v|=. That indentation makes the code rewiew clearer. Regards, Philippe _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
