On Fri, 17 Jun 2016, Daniel Walton wrote:
On Fri, Jun 17, 2016 at 4:58 AM, Paul Jakma <[email protected]> wrote:
Hi,
Is it just me, or does this patch leak attr->aspath? I've highlighted the
bits that made me ask that. Though, to be fair, if so then it looks like
the old remove-private-as also leaked.
I'd suggest separating lifetime management from the manipulation. Have
aspath_replace_private_asns and aspath_remove_private_asns just act on the
given aspath, and have the caller handle lifetime.
Agreed on both...looks like this is leaking and it seems better to just
have these modify the aspath instead of creating a dup that is modified.
Cool. So not just my eyes.
Do you want to respin a new patch for Quagga, or ... ?
regards,
--
Paul Jakma | [email protected] | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
Post-it Note Sludge leaked into the monitor.
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
