On Fri, Jun 24, 2016 at 5:47 AM, Paul Jakma <[email protected]> wrote: > On Fri, 17 Jun 2016, Daniel Walton wrote: > > On Fri, Jun 17, 2016 at 4:58 AM, Paul Jakma <[email protected]> wrote: >> >> Hi, >>> >>> Is it just me, or does this patch leak attr->aspath? I've highlighted the >>> bits that made me ask that. Though, to be fair, if so then it looks like >>> the old remove-private-as also leaked. >>> >>> I'd suggest separating lifetime management from the manipulation. Have >>> aspath_replace_private_asns and aspath_remove_private_asns just act on >>> the >>> given aspath, and have the caller handle lifetime. >>> >>> >>> Agreed on both...looks like this is leaking and it seems better to just >> have these modify the aspath instead of creating a dup that is modified. >> > > Cool. So not just my eyes. > > Do you want to respin a new patch for Quagga, or ... ?
I'm pretty swamped right now but will try to get back to it to fix it up in a couple of weeks. Daniel
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
